linux-kernel - Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hr2bbukyb.wl-tiwai@suse.de>
Date:   Wed, 13 Mar 2019 11:29:00 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Arnd Bergmann" <arnd@...db.de>
Cc:     "Thierry Reding" <thierry.reding@...il.com>,
        "Jonathan Hunter" <jonathanh@...dia.com>,
        "Jaroslav Kysela" <perex@...ex.cz>, <alsa-devel@...a-project.org>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        "Mohan Kumar D" <mkumard@...dia.com>,
        "Ravindra Lokhande" <rlokhande@...dia.com>,
        "Sameer Pujar" <spujar@...dia.com>, <linux-kernel@...r.kernel.org>,
        <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH] ALSA: hda/tegra: avoid build error without CONFIG_PM

On Mon, 04 Mar 2019 21:33:25 +0100,
Arnd Bergmann wrote:
> 
> The #ifdef protection around the PM functions is wrong, leading to
> a failed reference in some configurations:
> 
> sound/pci/hda/hda_tegra.c: In function 'hda_tegra_runtime_suspend':
> sound/pci/hda/hda_tegra.c:273:2: error: implicit declaration of function 'hda_tegra_disable_clocks'; did you mean 'hda_tegra_enable_clocks'? [-Werror=implicit-function-declaration]
> 
> Better remove the #ifdefs entirely and rely on the compiler silently
> dropping unused functions marked __maybe_unused.
> 
> Fixes: 707e0759f2f4 ("ALSA: hda/tegra: implement runtime suspend/resume")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied now.  Thanks.


Takashi