lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Mar 2019 09:40:25 +0800 From: Chen Yu <chenyu56@...wei.com> To: Rob Herring <robh@...nel.org> CC: <liuyu712@...ilicon.com>, <linux-usb@...r.kernel.org>, <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <john.stultz@...aro.org>, <suzhuangluan@...ilicon.com>, <kongfei@...ilicon.com>, <wanghu17@...ilicon.com>, <butao@...ilicon.com>, <chenyao11@...wei.com>, <fangshengzhou@...ilicon.com>, <lipengcheng8@...wei.com>, <songxiaowei@...ilicon.com>, <xuyiping@...ilicon.com>, <xuyoujun4@...wei.com>, <yudongbin@...ilicon.com>, <zangleigang@...ilicon.com>, Mark Rutland <mark.rutland@....com>, "Binghui Wang" <wangbinghui@...ilicon.com> Subject: Re: [PATCH v3 01/12] dt-bindings: phy: Add support for HiSilicon's hi3660 USB PHY Hi Rob, On 2019/3/12 21:45, Rob Herring wrote: > On Sat, Mar 02, 2019 at 05:04:54PM +0800, Yu Chen wrote: >> This patch adds binding documentation for supporting the hi3660 usb >> phy on boards like the HiKey960. >> >> Cc: Rob Herring <robh+dt@...nel.org> >> Cc: Mark Rutland <mark.rutland@....com> >> Cc: John Stultz <john.stultz@...aro.org> >> Cc: Binghui Wang <wangbinghui@...ilicon.com> >> Signed-off-by: Yu Chen <chenyu56@...wei.com> >> --- >> v1: >> * Fix some format error as suggested by Rob. >> v2: >> * Change hi3660 usb PHY to hi3660 USB PHY >> v3: >> * Make device node a subnode of usb3_otg_bc register. >> --- >> --- >> .../devicetree/bindings/phy/phy-hi3660-usb3.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt >> >> diff --git a/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt >> new file mode 100644 >> index 000000000000..6096214a2bc6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/phy/phy-hi3660-usb3.txt >> @@ -0,0 +1,28 @@ >> +Hisilicon hi3660 USB PHY >> +----------------------- >> + >> +Required properties: >> +- compatible: should be "hisilicon,hi3660-usb-phy" >> +- #phy-cells: must be 0 >> +- hisilicon,pericrg-syscon: phandle of syscon used to control phy. >> +- hisilicon,pctrl-syscon: phandle of syscon used to control phy. >> +- hisilicon,usb3-otg-bc-syscon: phandle of syscon used to control phy. > > You can drop this as it is now just the parent node. > >> +- hisilicon,eye-diagram-param: parameter set for phy >> +Refer to phy/phy-bindings.txt for the generic PHY binding properties >> + >> +This is a subnode of usb3_otg_bc register node. >> + >> +Example: >> + usb3_otg_bc: usb3_otg_bc@...00000 { >> + compatible = "syscon", "simple-mfd"; > > This node should have a specific compatible. > Do you mean I need write a specific driver for this node ? >> + reg = <0x0 0xff200000 0x0 0x1000>; >> + >> + usb-phy { >> + compatible = "hisilicon,hi3660-usb-phy"; >> + #phy-cells = <0>; >> + hisilicon,pericrg-syscon = <&crg_ctrl>; >> + hisilicon,pctrl-syscon = <&pctrl>; >> + hisilicon,usb3-otg-bc-syscon = <&usb3_otg_bc>; >> + hisilicon,eye-diagram-param = <0x22466e4>; >> + }; >> + }; >> -- >> 2.15.0-rc2 >> > > . > Thanks Yu Chen
Powered by blists - more mailing lists