lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Mar 2019 09:55:34 -0300 From: Paul Cercueil <paul@...pouillou.net> To: Miquel Raynal <miquel.raynal@...tlin.com> Cc: David Woodhouse <dwmw2@...radead.org>, Brian Norris <computersforpeace@...il.com>, Boris Brezillon <bbrezillon@...nel.org>, Marek Vasut <marek.vasut@...il.com>, Richard Weinberger <richard@....at>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, Harvey Hunt <harveyhuntnexus@...il.com>, linux-mtd@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 1/9] dt-bindings: mtd: ingenic: Add compatible strings for JZ4740 and JZ4725B Hi, Le lun. 4 mars 2019 à 15:51, Miquel Raynal <miquel.raynal@...tlin.com> a écrit : > Hi Paul, > >> >> --- >> a/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> >> +++ >> b/Documentation/devicetree/bindings/mtd/ingenic,jz4780-nand.txt >> >> @@ -6,7 +6,10 @@ memory-controllers/ingenic,jz4780-nemc.txt), >> and >> thus NAND device nodes must >> >> be children of the NEMC node. >> >> >> Required NAND controller device properties: >> >> -- compatible: Should be set to "ingenic,jz4780-nand". >> >> +- compatible: Should be one of: >> >> + * ingenic,jz4740-nand >> >> + * ingenic,jz4725b-nand >> >> + * ingenic,jz4780-nand >> > >> > Wouldn't "-nand-controller" suffix be better? Of course in the >> driver >> > you should still check for jz4780-nand. >> >> So I would be compatible with: >> * ingenic,jz4740-nand-controller >> * ingenic,jz4725b-nand-controller >> * ingenic,jz4780-nand >> ? > > From a driver POV I would even prefer ingenic,jz4780-nand-controller. > I > don't know what's best here. Maybe Boris or Rob can help? The "ingenic,jz4780-nand" compatible string is already out there and used in devicetree files, so I wouldn't change it just for the sake of it. -Paul
Powered by blists - more mailing lists