linux-kernel - Re: [PATCH] clocksource: cadence_ttc: fix memory leak in ttc_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <127508c8-6275-2ecb-5b7a-4aea1b7c45ba@xilinx.com>
Date:   Wed, 13 Mar 2019 14:55:49 +0100
From:   Michal Simek <michal.simek@...inx.com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Yue Haibing <yuehaibing@...wei.com>, <michal.simek@...inx.com>,
        <tglx@...utronix.de>
CC:     <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] clocksource: cadence_ttc: fix memory leak in
 ttc_setup_clockevent

On 09. 03. 19 15:24, Daniel Lezcano wrote:
> 
> Hi Yue,
> 
> I appreciate the fix but usually we add a rollback for all the
> operations done in the init function.
> 
> Please, migrate the init function to the timer-of API, so the rollback
> will be automatically handled.
> 
> Example here:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/clocksource/timer-sprd.c#n197

I have put a record to Xilinx database to take a look at it when we have
time.

Thanks,
Michal