linux-kernel - Indirect call in vesafb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190313145418.bwta37cogo7a4qtt@K55DR>
Date:   Wed, 13 Mar 2019 17:54:18 +0300
From:   Alexander Pateenok <pateenoc@...il.com>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Indirect call in vesafb driver

Hi,

There're several indirect calls in inline assembly in vesafb driver
(drivers/video/fbdev/vesafb.c), and these calls cannot be automatically
changed to retpolines. It's in vesafb_pan_display():

   73        __asm__ __volatile__(
   74                "call *(%%edi)"

and in vesa_setpalette():

  113        __asm__ __volatile__(
  114         "call *(%%esi)"

Is there need to use CALL_NOSPEC ?

Thanks, Alex