linux-kernel - Re: [PATCH v7 02/12] perf record: implement -f,--mmap-flush=<threshold> option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8adaa965-8ddd-e67a-975a-495a9cda6e38@linux.intel.com>
Date:   Wed, 13 Mar 2019 18:00:46 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 02/12] perf record: implement
 -f,--mmap-flush=<threshold> option


On 13.03.2019 17:36, Jiri Olsa wrote:
> On Tue, Mar 12, 2019 at 08:12:23AM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>>  	record__aio_mmap_read_sync(rec);
>>  
>>  	if (forks) {
>> @@ -1815,6 +1863,7 @@ static struct record record = {
>>  			.uses_mmap   = true,
>>  			.default_per_cpu = true,
>>  		},
>> +		.mmap_flush          = MMAP_FLUSH_DEFAULT,
>>  	},
>>  	.tool = {
>>  		.sample		= process_sample_event,
>> @@ -1881,6 +1930,9 @@ static struct option __record_options[] = {
>>  	OPT_CALLBACK('m', "mmap-pages", &record.opts, "pages[,pages]",
>>  		     "number of mmap data pages and AUX area tracing mmap pages",
>>  		     record__parse_mmap_pages),
>> +	OPT_CALLBACK('f', "mmap-flush", &record.opts, "bytes",
>> +		     "Minimal number of bytes that is extracted from mmap data pages (default: 1)",
>> +		     record__mmap_flush_parse),
> 
> let's not consume the 'f' for this option, just --map-flush

in v8.

~Alexey

> 
> jirka
>