[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190313160749.GB31891@cmpxchg.org>
Date: Wed, 13 Mar 2019 12:07:49 -0400
From: Johannes Weiner <hannes@...xchg.org>
To: Roman Gushchin <guroan@...il.com>
Cc: linux-mm@...ck.org, kernel-team@...com,
linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
Rik van Riel <riel@...riel.com>,
Michal Hocko <mhocko@...nel.org>, Roman Gushchin <guro@...com>
Subject: Re: [PATCH v2 6/6] mm: refactor memcg_hotplug_cpu_dead() to use
memcg_flush_offline_percpu()
On Tue, Mar 12, 2019 at 03:34:04PM -0700, Roman Gushchin wrote:
> @@ -2180,50 +2179,8 @@ static int memcg_hotplug_cpu_dead(unsigned int cpu)
> + for_each_mem_cgroup(memcg)
> + memcg_flush_offline_percpu(memcg, get_cpu_mask(cpu));
cpumask_of(cpu) is the official API function, with kerneldoc and
everything. I think get_cpu_mask() is just an implementation helper.
[hannes@...puter linux]$ git grep cpumask_of | wc -l
400
[hannes@...puter linux]$ git grep get_cpu_mask | wc -l
20
Otherwise, looks good to me!
Powered by blists - more mailing lists