linux-kernel - Re: [PATCH] um: define set_pte_at() as a static inline function, not a macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 13 Mar 2019 16:20:32 +0000
From:   Anton Ivanov <anton.ivanov@...bridgegreys.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>, Jeff Dike <jdike@...toit.com>,
        Richard Weinberger <richard@....at>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] um: define set_pte_at() as a static inline function, not
 a macro



On 13/03/2019 10:14, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> 
> When defined as macro, the mm argument is unused and subsequently the
> variable passed as mm is considered unused by the compiler. This fixes
> a build warning.
> 
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>   arch/um/include/asm/pgtable.h | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/um/include/asm/pgtable.h b/arch/um/include/asm/pgtable.h
> index 9c04562310b3..b377df76cc28 100644
> --- a/arch/um/include/asm/pgtable.h
> +++ b/arch/um/include/asm/pgtable.h
> @@ -263,7 +263,12 @@ static inline void set_pte(pte_t *pteptr, pte_t pteval)
>   	*pteptr = pte_mknewpage(*pteptr);
>   	if(pte_present(*pteptr)) *pteptr = pte_mknewprot(*pteptr);
>   }
> -#define set_pte_at(mm,addr,ptep,pteval) set_pte(ptep,pteval)
> +
> +static inline void set_pte_at(struct mm_struct *mm, unsigned long addr,
> +			      pte_t *pteptr, pte_t pteval)
> +{
> +	set_pte(pteptr, pteval);
> +}
>   
>   #define __HAVE_ARCH_PTE_SAME
>   static inline int pte_same(pte_t pte_a, pte_t pte_b)
> 
Reviewed-by: Anton Ivanov <anton.ivanov@...bridgegreys.com>
Acked-by: Anton Ivanov <anton.ivanov@...bridgegreys.com>
-- 
Anton R. Ivanov
Cambridgegreys Limited. Registered in England. Company Number 10273661
https://www.cambridgegreys.com/