linux-kernel - Re: [PATCH RFT] regulator: lp87565: Fix missing register for LP87565_BUCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f90d4497-a174-352b-6f1e-0b8de19088ec@ti.com>
Date:   Wed, 13 Mar 2019 10:26:46 +0530
From:   Keerthy <j-keerthy@...com>
To:     Axel Lin <axel.lin@...ics.com>, Mark Brown <broonie@...nel.org>
CC:     Liam Girdwood <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RFT] regulator: lp87565: Fix missing register for
 LP87565_BUCK_0



On 01/03/19 11:46 AM, Axel Lin wrote:
> LP87565_BUCK_0 is missed, fix it.
> 
> Fixes: f0168a9bf ("regulator: lp87565: Add support for lp87565 PMIC regulators")
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
> Hi J Keerthy,
> While reading the code, it seems strange that LP87565_BUCK_0 is never used.
> So current code only register 3 BUCKs for lp87565-regulator.
> Can you confirm if this fix is correct or not?

Axel,

If you look at the if check later:

if (lp87565->dev_type == LP87565_DEVICE_TYPE_LP87565_Q1) {

Currently the device that i am using only uses LP87565_BUCK_10 and
LP87565_BUCK_23(dual phase).

So your patch definitely makes sense when all 4 are used individually. 
Thanks for catching this.

Reviewed-by: Keerthy <j-keerthy@...com>

> 
> Thanks,
> Axel
>   drivers/regulator/lp87565-regulator.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/regulator/lp87565-regulator.c b/drivers/regulator/lp87565-regulator.c
> index 4ed41731a5b1..0418e478c6dc 100644
> --- a/drivers/regulator/lp87565-regulator.c
> +++ b/drivers/regulator/lp87565-regulator.c
> @@ -193,7 +193,7 @@ static int lp87565_regulator_probe(struct platform_device *pdev)
>   	struct lp87565 *lp87565 = dev_get_drvdata(pdev->dev.parent);
>   	struct regulator_config config = { };
>   	struct regulator_dev *rdev;
> -	int i, min_idx = LP87565_BUCK_1, max_idx = LP87565_BUCK_3;
> +	int i, min_idx = LP87565_BUCK_0, max_idx = LP87565_BUCK_3;
>   
>   	platform_set_drvdata(pdev, lp87565);
>   
>