linux-kernel - Re: [RFC PATCH 0/7] tracing: Use common error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 13 Mar 2019 15:15:04 -0500
From:   Tom Zanussi <zanussi@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     tglx@...utronix.de, namhyung@...nel.org, bigeasy@...utronix.de,
        joel@...lfernandes.org, linux-kernel@...r.kernel.org,
        linux-rt-users@...r.kernel.org
Subject: Re: [RFC PATCH 0/7] tracing: Use common error_log with probe events

Hi Masami,

On Wed, 2019-03-13 at 21:27 +0900, Masami Hiramatsu wrote:
> Hi Tom,
> 
> Here is a series of patches which applies common error_log framework
> to
> probe events. While applying it, I found I missed to check some
> errors
> in parser. Also, I made a testcase for this feature (only for kprobe
> event side, please make your test for the hist errors too).

Yep, will update the hist errors case too.

> Thus I made this as a series which contains some bugfixes (a kind of
> hardening), cleanups, and a test besides of the main patch.
> 
> Please feel free to pick this series to your series. I think some
> bugfixes might be better to push Steve's urgent branch.
> Let's talk with Steve.
> 

Thanks for doing this!  I'll try them out and pick up anything Steve
doesn't.

Tom

> Oh, note that this series can be applied on your v3 series, except
> for [4/5] :)
> 
> Thank you,
> 
> ---
> 
> Masami Hiramatsu (7):
>       tracing/probe: Check maxactive error cases
>       tracing/probe: Check event name length correctly
>       tracing/probe: Check the size of argument name and body
>       tracing/probe: Check event/group naming rule at parsing
>       tracing/probe: Verify alloc_trace_*probe() result
>       tracing: Use tracing error_log with probe events
>       selftests/ftrace: Add error_log testcase for kprobe errors
> 
> 
>  kernel/trace/trace_kprobe.c                        |   90 ++++--
>  kernel/trace/trace_probe.c                         |  280
> +++++++++++++++-----
>  kernel/trace/trace_probe.h                         |   76 +++++
>  kernel/trace/trace_uprobe.c                        |   43 ++-
>  .../ftrace/test.d/kprobe/kprobe_syntax_errors.tc   |   91 +++++++
>  5 files changed, 449 insertions(+), 131 deletions(-)
>  create mode 100644
> tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
> 
> --
> Masami Hiramatsu <mhiramat@...nel.org>