linux-kernel - RE: [PATCH] KVM: arm/arm64: Set ICH_HCR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <F348A9E21A573744858FF7E5D32E29D81FEFC965@DGGEMI529-MBX.china.huawei.com>
Date:   Thu, 14 Mar 2019 08:05:24 +0000
From:   "Tangnianyao (ICT)" <tangnianyao@...wei.com>
To:     Marc Zyngier <marc.zyngier@....com>,
        Shameerali Kolothum Thodi 
        <shameerali.kolothum.thodi@...wei.com>,
        Christoffer Dall <christoffer.dall@....com>,
        "james.morse@....com" <james.morse@....com>,
        "julien.thierry@....com" <julien.thierry@....com>,
        "suzuki.poulose@....com" <suzuki.poulose@....com>,
        "catalin.marinas@....com" <catalin.marinas@....com>,
        "will.deacon@....com" <will.deacon@....com>,
        "alex.bennee@...aro.org" <alex.bennee@...aro.org>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "andre.przywara@....com" <andre.przywara@....com>,
        Zhangshaokun <zhangshaokun@...ilicon.com>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "kvmarm@...ts.cs.columbia.edu" <kvmarm@...ts.cs.columbia.edu>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Tangnianyao (ICT)" <tangnianyao@...wei.com>
Subject: RE: [PATCH] KVM: arm/arm64: Set ICH_HCR_EN in guest anyway when
 using gicv4

Hi, Marc, Shameer

> -----Original Message-----
> From: Marc Zyngier [mailto:marc.zyngier@....com]
> Sent: Thursday, March 14, 2019 12:31 AM
> To: Shameerali Kolothum Thodi <shameerali.kolothum.thodi@...wei.com>;
> Tangnianyao (ICT) <tangnianyao@...wei.com>; Christoffer Dall
> <christoffer.dall@....com>; james.morse@....com; julien.thierry@....com;
> suzuki.poulose@....com; catalin.marinas@....com; will.deacon@....com;
> alex.bennee@...aro.org; mark.rutland@....com; andre.przywara@....com;
> Zhangshaokun <zhangshaokun@...ilicon.com>; keescook@...omium.org;
> linux-arm-kernel@...ts.infradead.org; kvmarm@...ts.cs.columbia.edu;
> linux-kernel@...r.kernel.org
> Cc: Linuxarm <linuxarm@...wei.com>
> Subject: Re: [PATCH] KVM: arm/arm64: Set ICH_HCR_EN in guest anyway when
> using gicv4
> 
> On 13/03/2019 15:59, Shameerali Kolothum Thodi wrote:
> 
> Hi Shameer,
> 
> >> Can you please give the following patch a go? I can't test it, but
> >> hopefully you can.
> >
> > Thanks for your quick response. I just did a quick test on one of our
> > platforms with VHE+GICv4 and it seems to fix the performance issue we
> > were seeing when GICv4 is enabled.
> >
> > Test setup:
> >
> > Host connected to a PC over a 10G port.
> > Launch Guest with an assigned vf dev.
> > Run iperf from Guest,
> >
> > 5.0 kernel:
> > [ ID]  Interval       Transfer     Bandwidth
> > [  3]  0.0-10.0 sec  1.30 GBytes  1.12 Gbits/sec
> >
> > +Patch:
> >
> > [ ID] 	Interval       Transfer     Bandwidth
> > [  3]  0.0-10.0 sec  10.9 GBytes  9.39 Gbits/sec
> 
> Ah, that looks much better! I'll try to write it properly, as I think what we have
> today is slightly bizarre (we write ICH_HCR_EL2 from too many paths, and I
> need to remember how the whole thing works).
> 
> Thanks,
> 
> 	M.
> --
> Jazz is not dead. It just smells funny...

Test setup:
VHE enable. 
Connected to an intel 8180 server over 10G port.
Launch guest with an assigned vf dev.
Intel server as server. Arm guest vm as client.
Run netperf in guest, package length 512byte:

5.0.0-rc3 kernel:
without patch:
2600 Mbits/s
with patch:
5800 Mbits/s


Thanks,
-Nianyao Tang