linux-kernel - Re: Re: [External] Re: vmscan: Reclaim unevictable pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Mar 2019 12:25:34 +0300
From:   Kirill Tkhai <ktkhai@...tuozzo.com>
To:     Pankaj Suryawanshi <pankaj.suryawanshi@...fochips.com>,
        Michal Hocko <mhocko@...nel.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "minchan@...nel.org" <minchan@...nel.org>
Subject: Re: Re: [External] Re: vmscan: Reclaim unevictable pages

On 14.03.2019 11:52, Pankaj Suryawanshi wrote:
> 
> I am using kernel version 4.14.65 (on Android pie [ARM]).
> 
> No additional patches applied on top of vanilla.(Core MM).
> 
> If  I change in the vmscan.c as below patch, it will work. 

Sorry, but 4.14.65 does not have braces around trylock_page(),
like in your patch below.

See https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/mm/vmscan.c?h=v4.14.65

[...]

>> diff --git a/mm/vmscan.c b/mm/vmscan.c
>> index be56e2e..2e51edc 100644
>> --- a/mm/vmscan.c
>> +++ b/mm/vmscan.c
>> @@ -990,15 +990,17 @@ static unsigned long shrink_page_list(struct list_head *page_list,
>>                  page = lru_to_page(page_list);
>>                  list_del(&page->lru);
>>
>>                 if (!trylock_page(page)) {
>>                          goto keep;
>>                 }