linux-kernel - Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of device_name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Mar 2019 10:31:11 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Rasmus Villemoes <linux@...musvillemoes.dk>
Cc:     Pavel Machek <pavel@....cz>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        LKML <linux-kernel@...r.kernel.org>, linux-leds@...r.kernel.org
Subject: Re: [PATCH 2/4] leds: netdev trigger: factor out middle part of
 device_name_store

Hello,

On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote:
> +static void set_device(struct led_netdev_data *trigger_data,
> +		       const char *buf, size_t size)

"set_device" is a very generic name. Can you please prefix it with
"ledtrig_netdev_"?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |