linux-kernel - Re: [PATCH] staging: media: imx7-mipi-csis: fix debugfs compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Mar 2019 10:17:51 +0000
From:   Rui Miguel Silva <rmfrfs@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Steve Longerbeam <slongerbeam@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        NXP Linux Team <linux-imx@....com>,
        Hans Verkuil <hverkuil-cisco@...all.nl>,
        linux-media@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: imx7-mipi-csis: fix debugfs compilation

Hi Arnd,
Thanks for the patch.
On Wed 13 Mar 2019 at 21:17, Arnd Bergmann wrote:
> When CONFIG_DEBUGFS is enabled, we get a warning about an
> incorrect section annotation that can lead to undefined
> behavior:
>
> WARNING: vmlinux.o(.text+0xd3c7c4): Section mismatch in 
> reference from the function mipi_csis_probe() to the function 
> .init.text:mipi_csis_debugfs_init()
> The function mipi_csis_probe() references
> the function __init mipi_csis_debugfs_init().
> This is often because mipi_csis_probe lacks a __init
> annotation or the annotation of mipi_csis_debugfs_init is wrong.
>
> The same function for an unknown reason has a different
> version for !CONFIG_DEBUGFS, which does not have this problem,
> but behaves the same way otherwise (it does nothing when debugfs
> is disabled).
> Consolidate the two versions, using the correct section from
> one version, and the implementation from the other.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Reviewed-by: Rui Miguel Silva <rmfrfs@...il.com>

---
Cheers,
	Rui

> ---
>  drivers/staging/media/imx/imx7-mipi-csis.c | 16 
>  ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c 
> b/drivers/staging/media/imx/imx7-mipi-csis.c
> index 2ddcc42ab8ff..001ce369ec45 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -9,6 +9,7 @@
>   */
>  
>  #include <linux/clk.h>
> +#include <linux/debugfs.h>
>  #include <linux/delay.h>
>  #include <linux/errno.h>
>  #include <linux/interrupt.h>
> @@ -889,8 +890,6 @@ static int mipi_csis_subdev_init(struct 
> v4l2_subdev *mipi_sd,
>  	return ret;
>  }
>  
> -#ifdef CONFIG_DEBUG_FS
> -#include <linux/debugfs.h>
>  
>  static int mipi_csis_dump_regs_show(struct seq_file *m, void 
>  *private)
>  {
> @@ -900,7 +899,7 @@ static int mipi_csis_dump_regs_show(struct 
> seq_file *m, void *private)
>  }
>  DEFINE_SHOW_ATTRIBUTE(mipi_csis_dump_regs);
>  
> -static int __init_or_module mipi_csis_debugfs_init(struct 
> csi_state *state)
> +static int mipi_csis_debugfs_init(struct csi_state *state)
>  {
>  	struct dentry *d;
>  
> @@ -934,17 +933,6 @@ static void mipi_csis_debugfs_exit(struct 
> csi_state *state)
>  	debugfs_remove_recursive(state->debugfs_root);
>  }
>  
> -#else
> -static int mipi_csis_debugfs_init(struct csi_state *state 
> __maybe_unused)
> -{
> -	return 0;
> -}
> -
> -static void mipi_csis_debugfs_exit(struct csi_state *state 
> __maybe_unused)
> -{
> -}
> -#endif
> -
>  static int mipi_csis_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;