linux-kernel - Re: [PATCH] tty: ipwireless: fix missing checks for ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190314123550.GI31119@suse.cz>
Date:   Thu, 14 Mar 2019 13:35:51 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Kangjie Lu <kjlu@....edu>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <JSlaby@...e.com>, pakki001@....edu,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: ipwireless: fix missing checks for ioremap

On Thu, Mar 14, 2019 at 02:05:32AM -0500, Kangjie Lu wrote:
> ipw->attr_memory and ipw->common_memory are assigned with the
>  return value of ioremap. ioremap may fail, but not checks
> are enforced. The fix insertss the checks.

Please fix the typos and resend, otherwise ok. Thanks.
> 
> Signed-off-by: Kangjie Lu <kjlu@....edu>

Reviewed-by: David Sterba <dsterba@...e.com>