linux-kernel - Re: [PATCH] appletalk: Fix potential NULL pointer dereference in unregister_snap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 14 Mar 2019 11:18:43 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     David Miller <davem@...emloft.net>
CC:     <joe@...ches.com>, <gregkh@...uxfoundation.org>,
        <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH] appletalk: Fix potential NULL pointer dereference in
 unregister_snap_client

On 2019/3/14 5:03, David Miller wrote:
> From: Yue Haibing <yuehaibing@...wei.com>
> Date: Tue, 12 Mar 2019 10:04:26 +0800
> 
>>  	timer_setup(&aarp_timer, aarp_expire_timeout, 0);
>>  	aarp_timer.expires  = jiffies + sysctl_aarp_expiry_time;
>>  	add_timer(&aarp_timer);
>> -	register_netdevice_notifier(&aarp_notifier);
>> +	rc = register_netdevice_notifier(&aarp_notifier);
>> +	if (rc)
>> +		unregister_snap_client(aarp_dl);
>> +	return rc;
> 
> You've left the timer running in this error path.

Oops, sorry, I'll resend to fix it.
> 
> .
>