linux-kernel - Re: [PATCH 1/5] lib/sort: Make swap functions more generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1145741552593595@sas2-2074c606c35d.qloud-c.yandex.net>
Date:   Thu, 14 Mar 2019 22:59:55 +0300
From:   Andrey Abramov <st5pub@...dex.ru>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        George Spelvin <lkml@....org>
Cc:     "geert@...ux-m68k.org" <geert@...ux-m68k.org>,
        "13@....org" <13@....org>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "daniel.wagner@...mens.com" <daniel.wagner@...mens.com>,
        "dchinner@...hat.com" <dchinner@...hat.com>,
        "don.mullis@...il.com" <don.mullis@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux@...musvillemoes.dk" <linux@...musvillemoes.dk>
Subject: Re: [PATCH 1/5] lib/sort: Make swap functions more generic

> Pistols at dawn?

> swap_bytes
> swap_4byte_words
> swap_8byte_words
or
>  swap_bytes / swap_ints / swap_longs
>  swap_1 / swap_4 / swap_8

Yes, in my opinion, swap_bytes / swap_ints / swap_longs are the most readable because we have both swap_ints and swap_longs functions (in one file near each other), so I don't think that there will be any confusion about size. 
But actually, it doesn't matter which name will you take, because the meaning of each, in my opinion, is obvious enough, so I don't mind about any of these options.

-- 
With Best Regards,
Andrey Abramov