linux-kernel - Re: [PATCH 2/2] elf: print userspace address with %lx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315065327.GA15672@dhcp22.suse.cz>
Date:   Fri, 15 Mar 2019 07:53:27 +0100
From:   Michal Hocko <mhocko@...nel.org>
To:     Alexey Dobriyan <adobriyan@...il.com>
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] elf: print userspace address with %lx

On Thu 14-03-19 23:45:48, Alexey Dobriyan wrote:
> Use %lx, save a cast.
> 
> "addr" is userspace address so using (and mangling) pointer was never
> necessary.

There shouldn't be any mangling AFAIU. Documentation for pointer()
says

 * - 'x' For printing the address. Equivalent to "%lx".

> 
> Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>
> ---
> 
>  fs/binfmt_elf.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- a/fs/binfmt_elf.c
> +++ b/fs/binfmt_elf.c
> @@ -376,8 +376,8 @@ static unsigned long elf_map(struct file *filep, unsigned long addr,
>  		map_addr = vm_mmap(filep, addr, size, prot, type, off);
>  
>  	if ((type & MAP_FIXED_NOREPLACE) && map_addr == -EEXIST)
> -		pr_info("%d (%s): Uhuuh, elf segment at %px requested but the memory is mapped already\n",
> -			task_pid_nr(current), current->comm, (void *)addr);
> +		pr_info("%d (%s): Uhuuh, elf segment at %lx requested but the memory is mapped already\n",
> +			task_pid_nr(current), current->comm, addr);
>  
>  	return(map_addr);
>  }

-- 
Michal Hocko
SUSE Labs