linux-kernel - [PATCH] media: tw5864: Fix possible NULL pointer dereference in tw5864_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 15 Mar 2019 10:01:24 +0800
From:   Yue Haibing <yuehaibing@...wei.com>
To:     <maintainers@...echerrydvr.com>, <anton@...p.bluecherry.net>,
        <andrey.utkin@...p.bluecherry.net>, <mchehab@...nel.org>
CC:     <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        YueHaibing <yuehaibing@...wei.com>
Subject: [PATCH] media: tw5864: Fix possible NULL pointer dereference in tw5864_handle_frame

From: YueHaibing <yuehaibing@...wei.com>

'vb' null check should before dereference it in
tw5864_handle_frame, otherwise NULL pointer dereference
may occurs.

Fixes: 34d1324edd31 ("[media] pci: Add tw5864 driver")
Signed-off-by: YueHaibing <yuehaibing@...wei.com>
---
 drivers/media/pci/tw5864/tw5864-video.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/pci/tw5864/tw5864-video.c b/drivers/media/pci/tw5864/tw5864-video.c
index 5a1f3aa..434d313 100644
--- a/drivers/media/pci/tw5864/tw5864-video.c
+++ b/drivers/media/pci/tw5864/tw5864-video.c
@@ -1395,13 +1395,13 @@ static void tw5864_handle_frame(struct tw5864_h264_frame *frame)
 	input->vb = NULL;
 	spin_unlock_irqrestore(&input->slock, flags);
 
-	v4l2_buf = to_vb2_v4l2_buffer(&vb->vb.vb2_buf);
-
 	if (!vb) { /* Gone because of disabling */
 		dev_dbg(&dev->pci->dev, "vb is empty, dropping frame\n");
 		return;
 	}
 
+	v4l2_buf = to_vb2_v4l2_buffer(&vb->vb.vb2_buf);
+
 	/*
 	 * Check for space.
 	 * Mind the overhead of startcode emulation prevention.
-- 
2.7.0