linux-kernel - Re: [RFC PATCH v2 1/7] i2c: apply coding style for struct i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 15 Mar 2019 13:15:51 +0100
From:   Simon Horman <horms@...ge.net.au>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc:     linux-i2c@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Keerthy <j-keerthy@...com>, Peter Rosin <peda@...ntia.se>,
        Tony Lindgren <tony@...mide.com>,
        Russell King <linux@...linux.org.uk>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Stefan Lengfeld <contact@...fanchrist.eu>,
        Phil Reid <preid@...ctromag.com.au>,
        Tero Kristo <t-kristo@...com>, linux-omap@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/7] i2c: apply coding style for struct i2c_adapter

On Sat, Mar 02, 2019 at 02:47:29PM +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>

Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  include/linux/i2c.h | 23 +++++++++++++----------
>  1 file changed, 13 insertions(+), 10 deletions(-)
> 
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 383510b4f083..758a6db864c9 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -517,20 +517,23 @@ i2c_register_board_info(int busnum, struct i2c_board_info const *info,
>   * Documentation file Documentation/i2c/fault-codes.
>   */
>  struct i2c_algorithm {
> -	/* If an adapter algorithm can't do I2C-level access, set master_xfer
> -	   to NULL. If an adapter algorithm can do SMBus access, set
> -	   smbus_xfer. If set to NULL, the SMBus protocol is simulated
> -	   using common I2C messages */
> -	/* master_xfer should return the number of messages successfully
> -	   processed, or a negative value on error */
> +	/*
> +	 * If an adapter algorithm can't do I2C-level access, set master_xfer
> +	 * to NULL. If an adapter algorithm can do SMBus access, set
> +	 * smbus_xfer. If set to NULL, the SMBus protocol is simulated
> +	 * using common I2C messages.
> +	 *
> +	 * master_xfer should return the number of messages successfully
> +	 * processed, or a negative value on error
> +	 */
>  	int (*master_xfer)(struct i2c_adapter *adap, struct i2c_msg *msgs,
>  			   int num);
> -	int (*smbus_xfer) (struct i2c_adapter *adap, u16 addr,
> -			   unsigned short flags, char read_write,
> -			   u8 command, int size, union i2c_smbus_data *data);
> +	int (*smbus_xfer)(struct i2c_adapter *adap, u16 addr,
> +			  unsigned short flags, char read_write,
> +			  u8 command, int size, union i2c_smbus_data *data);
>  
>  	/* To determine what the adapter supports */
> -	u32 (*functionality) (struct i2c_adapter *);
> +	u32 (*functionality)(struct i2c_adapter *adap);
>  
>  #if IS_ENABLED(CONFIG_I2C_SLAVE)
>  	int (*reg_slave)(struct i2c_client *client);
> -- 
> 2.11.0
>