linux-kernel - Re: [PATCH] block: nbd: fix a missing check for nla_nest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190315132739.mfnbkp5vdjx2uhko@MacBook-Pro-91.local>
Date:   Fri, 15 Mar 2019 09:27:40 -0400
From:   Josef Bacik <josef@...icpanda.com>
To:     Kangjie Lu <kjlu@....edu>
Cc:     pakki001@....edu, Josef Bacik <josef@...icpanda.com>,
        Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        nbd@...er.debian.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] block: nbd: fix a missing check for nla_nest_start

On Fri, Mar 15, 2019 at 01:31:38AM -0500, Kangjie Lu wrote:
> nla_nest_start may fail and thus deserves a check.
> 
> The fix inserts such a check and exits gracefully in case it
> fails.
> 

Except it won't because we pre-reserve enough space for that attr.  Subsequent
calls could fail, and those are checked properly, but this one won't.  Thanks,

Josef