linux-kernel - Re: [PATCH serial v3] sc16is7xx: missing unregister/delete driver on error in sc16is7xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <566a03ba-aae9-3169-5db3-3417d5eb60f9@huawei.com>
Date:   Fri, 15 Mar 2019 21:56:07 +0800
From:   maowenan <maowenan@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     <gregkh@...uxfoundation.org>, <jslaby@...e.com>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>, <vz@...ia.com>
Subject: Re: [PATCH serial v3] sc16is7xx: missing unregister/delete driver on
 error in sc16is7xx_init()

ping...

On 2019/3/11 20:19, Dan Carpenter wrote:
> On Mon, Mar 11, 2019 at 05:39:59PM +0800, Mao Wenan wrote:
>> Add the missing uart_unregister_driver() and i2c_del_driver() before
>> return from sc16is7xx_init() in the error handling case.
>>
>> Signed-off-by: Mao Wenan <maowenan@...wei.com>
>> Reviewed-by: Vladimir Zapolskiy <vz@...ia.com>
> 
> This looks nice.  Thanks!
> 
> Reviewed-by: Dan Carpeter <dan.carpenter@...cle.com>
> 
> regards,
> dan carpenter
> 
> 
>