linux-kernel - Re: [PATCH] tracing: initialize variable in create_dyn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 15 Mar 2019 08:56:45 -0700
From:   Frank Rowand <frowand.list@...il.com>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>
Cc:     linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...nel.org>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Ravi Bangoria <ravi.bangoria@...ux.vnet.ibm.com>
Subject: Re: [PATCH] tracing: initialize variable in create_dyn_event()

On 3/14/19 4:26 PM, Masami Hiramatsu wrote:
> Hi Frank and Steve,
> 
> Thank you for pointing it out :)
> 
> On Thu, 14 Mar 2019 18:19:08 -0400
> Steven Rostedt <rostedt@...dmis.org> wrote:
> 
>> On Thu, 14 Mar 2019 14:05:02 -0700
>> Frank Rowand <frowand.list@...il.com> wrote:
>>
>>> Hi Steve,
>>>
>>> Ping.
>>
>> Thanks, this got buried.
>>
>>>>  static int create_dyn_event(int argc, char **argv)
>>>>  {
>>>>  	struct dyn_event_operations *ops;
>>>> -	int ret;
>>>> +	int ret = 0;
>>
>> Probably should be ret = -ENODEV;
>>
>> As if ret doesn't get set, then no dynamic code has been registered,
>> and something is truly wrong.
> 
> I Agreed to return -ENODEV instead of 0.
> 
> Thank you,
> 
>>
>> -- Steve
>>
>>
>>>>  
>>>>  	if (argv[0][0] == '-' || argv[0][0] == '!')
>>>>  		return dyn_event_release(argc, argv, NULL);
>>>>   
>>
> 
> 

Thanks, I'll fix and resend.