linux-kernel - Re: [PATCH 4/5] lib/list_sort: Simplify and remove MAX_LIST_LENGTH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190315190614.GH9224@smile.fi.intel.com>
Date:   Fri, 15 Mar 2019 21:06:14 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Andrey Abramov <st5pub@...dex.ru>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        George Spelvin <lkml@....org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Daniel Wagner <daniel.wagner@...mens.com>,
        Dave Chinner <dchinner@...hat.com>,
        Don Mullis <don.mullis@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH 4/5] lib/list_sort: Simplify and remove
 MAX_LIST_LENGTH_BITS

On Fri, Mar 15, 2019 at 09:53:07PM +0300, Andrey Abramov wrote:
> > I'm trying to present the case to spur discussion, but it realy is
> > a *question* I'm asking about whether to do that, not a suggestion
> > phrased as a question.
> 
> > If it's just x86_64, use size_t everywhere, and let them suffer, for not
> > being real 64-bit ;-)
> 
> But what is the problem of local typedef with a good and clear comment?

It makes harder to read and understand the code. One needs spend deciseconds /
seconds to catch instead of santiseconds of time.

-- 
With Best Regards,
Andy Shevchenko