linux-kernel - Re: [GIT] SMB3 Fixes and debugging improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 15 Mar 2019 18:50:30 -0500
From:   Steve French <smfrench@...il.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     CIFS <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT] SMB3 Fixes and debugging improvements

Previous pull request text was truncated (last 25 lines of text
missing), resending.

Please pull the following changes since commit
f261c4e529dac5608a604d3dd3ae1cd2adf23c89:

  Merge branch 'akpm' (patches from Andrew) (2019-03-14 15:10:10 -0700)

are available in the Git repository at:

  git://git.samba.org/sfrench/cifs-2.6.git tags/5.1-rc-smb3

for you to fetch changes up to bc31d0cdcfbadb6258b45db97e93b1c83822ba33:

  CIFS: fix POSIX lock leak and invalid ptr deref (2019-03-14 19:32:36 -0500)

----------------------------------------------------------------
- Various additional dynamic tracing tracepoints
- Debugging improvements (including ability to query the server via
SMB3 fsctl from userspace tools which can help with stats and
debugging)
- One minor performance improvement (root directory inode caching)
- Crediting (SMB3 flow control) fixes
- Some cleanup (docs and to mknod)
- Important fixes: one to smb3 implementation of fallocate zero range
(which fixes three xfstests) and a POSIX lock fix
----------------------------------------------------------------
Aurelien Aptel (2):
      CIFS: make mknod() an smb_version_op
      CIFS: fix POSIX lock leak and invalid ptr deref

Ronnie Sahlberg (11):
      cifs: change wait_for_free_request() to take flags as argument
      cifs: pass flags down into wait_for_free_credits()
      cifs: wait_for_free_credits() make it possible to wait for >=1 credits
      cifs: prevent starvation in wait_for_free_credits for
multi-credit requests
      cifs: add a timeout argument to wait_for_free_credits
      cifs: simplify how we handle credits in compound_send_recv()
      cifs: cache FILE_ALL_INFO for the shared root handle
      cifs: add SMB2_ioctl_init/free helpers to be used with compounding
      cifs: fix smb3_zero_range so it can expand the file-size when required
      cifs: fix incorrect handling of smb2_set_sparse() return in
smb3_simple_falloc
      SMB3: Allow SMB3 FSCTL queries to be sent to server from tools

Steve French (9):
      smb3: display security information in /proc/fs/cifs/DebugData
more accurately
      smb3: add dynamic tracepoint for timeout waiting for credits
      smb3: display volume serial number for shares in /proc/fs/cifs/DebugData
      smb3: Add dynamic trace points for various compounded smb3 ops
      smb3: add dynamic tracepoints for simple fallocate and zero range
      SMB3: passthru query info doesn't check for SMB3 FSCTL passthru
      cifs: remove unused value pointed out by Coverity
      cifs: minor documentation updates
      smb2: fix typo in definition of a few error flags

 Documentation/filesystems/cifs/TODO     |   3 +-
 Documentation/filesystems/cifs/cifs.txt |  34 +++++++----
 fs/cifs/cifs_debug.c                    |  11 +++-
 fs/cifs/cifs_ioctl.h                    |   3 +
 fs/cifs/cifsglob.h                      |  16 ++++-
 fs/cifs/connect.c                       |   4 --
 fs/cifs/dir.c                           | 107 +--------------------------------
 fs/cifs/file.c                          |  14 ++++-
 fs/cifs/smb1ops.c                       | 126
+++++++++++++++++++++++++++++++++++++++
 fs/cifs/smb2inode.c                     |  87 ++++++++++++++++++++++++---
 fs/cifs/smb2ops.c                       | 423
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------
 fs/cifs/smb2pdu.c                       | 145
++++++++++++++++++++++++++-------------------
 fs/cifs/smb2pdu.h                       |   7 +++
 fs/cifs/smb2proto.h                     |   7 +++
 fs/cifs/smb2status.h                    |   6 +-
 fs/cifs/trace.h                         | 124
++++++++++++++++++++++++++++++++++++++
 fs/cifs/transport.c                     | 226
+++++++++++++++++++++++++++++++++++++--------------------------------
 17 files changed, 981 insertions(+), 362 deletions(-)

On Fri, Mar 15, 2019 at 6:39 PM Steve French <smfrench@...il.com> wrote:
>
> Please pull the following changes since commit
> f261c4e529dac5608a604d3dd3ae1cd2adf23c89:
>
>   Merge branch 'akpm' (patches from Andrew) (2019-03-14 15:10:10 -0700)
>
> are available in the Git repository at:
>
>   git://git.samba.org/sfrench/cifs-2.6.git tags/5.1-rc-smb3
>
> for you to fetch changes up to bc31d0cdcfbadb6258b45db97e93b1c83822ba33:
>
>   CIFS: fix POSIX lock leak and invalid ptr deref (2019-03-14 19:32:36 -0500)
>
> ----------------------------------------------------------------
> - Various additional dynamic tracing tracepoints
> - Debugging improvements (including ability to query the server via
> SMB3 fsctl from userspace tools which can help with stats and
> debugging)
> - One minor performance improvement (root directory inode caching)
> - Crediting (SMB3 flow control) fixes
> - Some cleanup (docs and to mknod)
> - Important fixes: one to smb3 implementation of fallocate zero range
> (which fixes three xfstests) and a POSIX lock fix
> ----------------------------------------------------------------
> Aurelien Aptel (2):
>       CIFS: make mknod() an smb_version_op
>       CIFS: fix POSIX lock leak and invalid ptr deref
>
> Ronnie Sahlberg (11):
>       cifs: change wait_for_free_request() to take flags as argument
>       cifs: pass flags down into wait_for_free_credits()
>       cifs: wait_for_free_credits() make it possible to wait for >=1 credits
>       cifs: prevent starvation in wait_for_free_credits for
> multi-credit requests
>       cifs: add a timeout argument to wait_for_free_credits
>       cifs: simplify how we handle credits in compound_send_recv()
>       cifs: cache FILE_ALL_INFO for the shared root handle
>       cifs: add SMB2_ioctl_init/free helpers to be used with compounding
>       cifs: fix smb3_zero_range so it can expand the file-size when required
>       cifs: fix incorrect handling of smb2_set_sparse() return in
> smb3_simple_falloc
>       SMB3: Allow SMB3 FSCTL queries to be sent to server from tools
>
> Steve French (9):
>       smb3: display security information in /proc/fs/cifs/DebugData
> more accurately
>       smb3: add dynamic tracepoint for timeout waiting for credits
>       smb3: display volume serial number for shares in /proc/fs/cifs/DebugData
>       smb3: Add dynamic trace points for various compounded smb3 ops
>       smb3: add dynamic tracepoints for simple fallocate and zero range
>       SMB3: passthru query info doesn't check for SMB3 FSCTL passthru
>       cifs: remove unused value pointed out by Coverity
>       cifs: minor documentation updates
>       smb2: fix typo in definition of a few error flags
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve