lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 16 Mar 2019 18:34:58 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de,
        pmeerw@...erw.net, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-usp@...glegroups.com
Subject: Re: [PATCH v4 1/7] staging: iio: ad5933: change multi-line comment
 style

On Sat, 16 Mar 2019 12:06:18 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> Make multi-line comments compliant with the preferred code style.
> 
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to hopefully ignore.

Thanks,

Jonathan

> ---
>  drivers/staging/iio/impedance-analyzer/ad5933.c | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c
> index 3134295f014f..05e2185bfdae 100644
> --- a/drivers/staging/iio/impedance-analyzer/ad5933.c
> +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c
> @@ -474,7 +474,8 @@ static IIO_DEVICE_ATTR(out_voltage0_settling_cycles, 0644,
>  			ad5933_store,
>  			AD5933_OUT_SETTLING_CYCLES);
>  
> -/* note:
> +/*
> + * note:
>   * ideally we would handle the scale attributes via the iio_info
>   * (read|write)_raw methods, however this part is a untypical since we
>   * don't create dedicated sysfs channel attributes for out0 and in0.
> @@ -572,7 +573,8 @@ static int ad5933_ring_postenable(struct iio_dev *indio_dev)
>  {
>  	struct ad5933_state *st = iio_priv(indio_dev);
>  
> -	/* AD5933_CTRL_INIT_START_FREQ:
> +	/*
> +	 * AD5933_CTRL_INIT_START_FREQ:
>  	 * High Q complex circuits require a long time to reach steady state.
>  	 * To facilitate the measurement of such impedances, this mode allows
>  	 * the user full control of the settling time requirement before
> @@ -663,7 +665,8 @@ static void ad5933_work(struct work_struct *work)
>  	}
>  
>  	if (status & AD5933_STAT_SWEEP_DONE) {
> -		/* last sample received - power down do
> +		/*
> +		 * last sample received - power down do
>  		 * nothing until the ring enable is toggled
>  		 */
>  		ad5933_cmd(st, AD5933_CTRL_POWER_DOWN);

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ