linux-kernel - Re: [GIT PULL] AFS fixes and other bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4841.1552722940@warthog.procyon.org.uk>
Date:   Sat, 16 Mar 2019 07:55:40 +0000
From:   David Howells <dhowells@...hat.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     dhowells@...hat.com, linux-afs@...ts.infradead.org,
        linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] AFS fixes and other bits

Linus Torvalds <torvalds@...ux-foundation.org> wrote:

> The thing hasn't even seen a compiler, and when you *do* show the code
> to a compiler, said compiler correctly warns about

No, it doesn't - at least not gcc-8.3.1 on Fedora 29.  What compiler are you
using?

> afs_do_silly_unlink() potentially returning an uninitialized variable.

Not only has it seen a compiler, it's also been tested numerous times, with
firefox, sqlite and some commands that tests file locking manually.

But please hold off for now.  I've just tried the system flock program - and
that causes a lock leakage message for some reason that needs investigating.

David