linux-kernel - Re: [PATCH] Use fall-through attribute rather than magic comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17a4be1ffdaf908ff02a51bf8dea707117067f9b.camel@perches.com>
Date:   Sat, 16 Mar 2019 01:08:04 -0700
From:   Joe Perches <joe@...ches.com>
To:     Shawn Landden <shawn@....icu>, linux-kernel@...r.kernel.org
Cc:     "Gustavo A . R . Silva" <gustavo@...eddedor.com>,
        Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] Use fall-through attribute rather than magic comments

On Fri, 2019-03-15 at 21:38 -0600, Shawn Landden wrote:
> The -Wimplicit-fallthrough warning recognizes magic comments
> https://developers.redhat.com/blog/2017/03/10/wimplicit-fallthrough-in-gcc-7/
> It is my opinion that magic comments are a bad idea. Comments should not
> change the interpretation (even regarding errors) of C code.
> (It also happens to break distcc as distcc compiles pre-processed .i files.)
> 
> I am aware this can cause some merge pain.
> 
> Also, if my style is OK, then needs some changes to checkpatch.pl. (CCed)

I think it's a pretty good idea
https://lkml.org/lkml/2017/2/10/485

It's generally better to add a patch first to the include
file and then conversion patches by subsystem instead of one
gigantic patch spanning multiple subsystems.

Or send a script that does the conversion.