linux-kernel - Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yw1x7ecx30kc.fsf@mansr.com>
Date:   Sun, 17 Mar 2019 16:52:51 +0000
From:   Måns Rullgård <mans@...sr.com>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Andy Shevchenko <andy.shevchenko@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> writes:

> On Tue, Mar 12, 2019 at 4:48 PM Måns Rullgård <mans@...sr.com> wrote:
>>
>> The current code unconditionally flashes the light once.  I though it
>> best to keep that behaviour as default, even if it's not seen as ideal.
>
> Sent into -next. If no one else says anything after a few days, I will
> send the series for -rc2.
>
> By the way, what about the other comment Andy mentioned? i.e.
> "defined(_OFF)" (in case you missed to answer it).

With a correct config, there should be no difference.  If someone
managed to create a config without any of the alternatives selected,
a compiler error would result.  I don't really have much of an opinion
on which behaviour is preferable in that situation.

-- 
Måns Rullgård