linux-kernel - Re: [PATCH] dma: mediatek: addres minor style issues flagged by clang-format.

Open Source and information security mailing list archives

Message-ID: <CAGp9LzoWhFzjryv1BhUyjNZOU-K7pgKji94n_7B-Bzbu2mJ1Ow@mail.gmail.com>
Date:   Sun, 17 Mar 2019 11:02:28 -0700
From:   Sean Wang <sean.wang@...nel.org>
To:     Armando Miraglia <arma2ff0@...il.com>
Cc:     Matthias Brugger <matthias.bgg@...il.com>,
        Neil Brown <neil@...wn.name>, devel@...verdev.osuosl.org,
        jbi.octave@...il.com, gustavo@...eddedor.com,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, sergio.paracuellos@...il.com,
        Armando Miraglia <armax@...gle.com>,
        linux-mediatek@...ts.infradead.org, bhanusreemahesh@...il.com,
        christian@...mp.de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] dma: mediatek: addres minor style issues flagged by clang-format.

On Sun, Mar 17, 2019 at 1:45 AM Armando Miraglia <arma2ff0@...il.com> wrote:
>
> Running clang-format on mtk-hsdma.c I noticed that few lines would not
> need to be wrapped, since they fit 80 columns. This change changes such
> lines to better fit the style-guide.
>
> Signed-off-by: Armando Miraglia <armax@...gle.com>
> ---
>  drivers/staging/mt7621-dma/mtk-hsdma.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 97571f1d697b..74c374f7bef4 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -264,8 +264,7 @@ static void mtk_hsdma_reset(struct mtk_hsdam_engine *hsdma,
>         /* init desc value */
>         for (i = 0; i < HSDMA_DESCS_NUM; i++) {
>                 chan->tx_ring[i].addr0 = 0;
> -               chan->tx_ring[i].flags = HSDMA_DESC_LS0 |
> -                       HSDMA_DESC_DONE;
> +               chan->tx_ring[i].flags = HSDMA_DESC_LS0 | HSDMA_DESC_DONE;
>         }
>         for (i = 0; i < HSDMA_DESCS_NUM; i++) {
>                 chan->rx_ring[i].addr0 = 0;
> @@ -435,8 +434,7 @@ static irqreturn_t mtk_hsdma_irq(int irq, void *devid)
>         if (likely(status & HSDMA_INT_RX_Q0))
>                 tasklet_schedule(&hsdma->task);
>         else
> -               dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n",
> -                       status);
> +               dev_dbg(hsdma->ddev.dev, "unhandle irq status %08x\n", status);
>         /* clean intr bits */
>         mtk_hsdma_write(hsdma, HSDMA_REG_INT_STATUS, status);
>

Acked-by: Sean Wang <sean.wang@...nel.org>

> --
> 2.21.0.360.g471c308f928-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives