linux-kernel - Re: [PATCH] IB/iser: remove uninitialized variable len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe379614-5b0c-4063-2153-bd8a792d51c6@mellanox.com>
Date:   Sun, 17 Mar 2019 12:05:28 +0200
From:   Max Gurtovoy <maxg@...lanox.com>
To:     Colin King <colin.king@...onical.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, <linux-rdma@...r.kernel.org>
CC:     <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] IB/iser: remove uninitialized variable len


On 3/17/2019 1:05 AM, Colin King wrote:
> From: Colin Ian King<colin.king@...onical.com>
>
> The variable len is not being inintialized and the uninitialized
> value is being returned. However, this return path is never reached
> because the default case in the switch statement returns -ENOSYS.
> Clean up the code by replacing the return -ENOSYS with a break
> for the default case and returning -ENOSYS at the end of the
> function.  This allows len to be removed.  Also remove redundant
> break that follows a return statement.
>
> Signed-off-by: Colin Ian King<colin.king@...onical.com>

Looks good,

Reviewed-by: Max Gurtovoy <maxg@...lanox.com>