linux-kernel - Re: [PATCH] xfrm6_tunnel: Fix potential panic when unloading xfrm6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190317101338.GQ6035@gauss3.secunet.de>
Date:   Sun, 17 Mar 2019 11:13:39 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Su Yanjun <suyj.fnst@...fujitsu.com>, <davem@...emloft.net>,
        <kuznet@....inr.ac.ru>, <yoshfuji@...ux-ipv6.org>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH] xfrm6_tunnel: Fix potential panic when unloading
 xfrm6_tunnel module

On Fri, Mar 15, 2019 at 02:24:38PM +0800, Herbert Xu wrote:
> On Thu, Mar 14, 2019 at 02:59:42PM +0800, Su Yanjun wrote:
> > When unloading xfrm6_tunnel module, xfrm6_tunnel_fini directly
> > frees the xfrm6_tunnel_spi_kmem. Maybe someone has gotten the
> > xfrm6_tunnel_spi, so need to wait it.
> > 
> > Fixes: 91cc3bb0b04ff("xfrm6_tunnel: RCU conversion")
> > Signed-off-by: Su Yanjun <suyj.fnst@...fujitsu.com>
> > ---
> >  net/ipv6/xfrm6_tunnel.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> 
> This looks good to me.  And it's not just the matter of accessing
> freed memory.  A worse problem would be trying to execute code
> from an unloaded module.
> 
> Acked-by: Herbert Xu <herbert@...dor.apana.org.au>

Applied, thanks everyone!