lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 17 Mar 2019 12:11:50 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Bharath Vedartham <linux.bhar@...il.com>
Cc:     gaoxiang25@...wei.com, yuchao0@...wei.com,
        linux-erofs@...ts.ozlabs.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: erofs: Add whitespace after declaration

On Sat, Mar 16, 2019 at 04:59:58PM +0530, Bharath Vedartham wrote:
> Fix the checkpatch.pl warning to add a whitespace after declaration
> statements.
> 
> Signed-off-by: Bharath Vedartham <linux.bhar@...il.com>
> ---
> Changes since v2
> 	- Mutt was giving me a few problems. I apologise for the
> 	  previous poor patches.
> ---
>  drivers/staging/erofs/inode.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/erofs/inode.c b/drivers/staging/erofs/inode.c
> index 924b8df..9a36a1f 100644
> --- a/drivers/staging/erofs/inode.c
> +++ b/drivers/staging/erofs/inode.c
> @@ -270,8 +270,8 @@ struct inode *erofs_iget(struct super_block *sb,
>  	if (inode->i_state & I_NEW) {
>  		int err;
>  		struct erofs_vnode *vi = EROFS_V(inode);
> -		vi->nid = nid;
>  
> +		vi->nid = nid;
>  		err = fill_inode(inode, isdir);
>  		if (likely(!err))
>  			unlock_new_inode(inode);
> @@ -305,4 +305,3 @@ const struct inode_operations erofs_fast_symlink_iops = {
>  #endif
>  	.get_acl = erofs_get_acl,
>  };
> -

You also removed the last line of the file, which you did not mention :(

Powered by blists - more mailing lists