linux-kernel - Re: [PATCHv2] staging: rtl8723bs: do not use __constant_cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190317151415.GA23308@tigerII.localdomain>
Date:   Mon, 18 Mar 2019 00:14:15 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCHv2] staging: rtl8723bs: do not use __constant_cpu_to_le16

On (03/17/19 13:16), Greg Kroah-Hartman wrote:
> On Sun, Mar 17, 2019 at 08:48:03PM +0900, Sergey Senozhatsky wrote:
> > From: Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
> 
> Why ".work"?

Aha, good question. There is not so much of a difference between .work and
!.work. (if any at all).

> > cpu_to_le16() is capable enough to detect __builtin_constant_p()
> > and to use an appropriate compile time ___constant_swahbXX()
> > function.
> > 
> > So we can use cpu_to_le16() instead of __constant_cpu_to_le16().
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> 
> Email address does not match up to the From: line above :(

Greg, sorry about that!
Either you were the first one to complaint or this was the first time
I re-rent a patch from a different google account.

	-ss