linux-kernel - Re: [PATCH] Bluetooth: mediatek: Fixed incorrect type in assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Mar 2019 02:09:53 +0800
From:   Sean Wang <sean.wang@...iatek.com>
To:     <marcel@...tmann.org>
CC:     <johan.hedberg@...il.com>, <linux-bluetooth@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Bluetooth: mediatek: Fixed incorrect type in assignment

this is just a gentle ping


On Tue, 2019-03-05 at 08:14 +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Fixed warning: incorrect type in assignment reported by kbuild test robot.
> The detailed warning is shown as below.
> 
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
> 
> All warnings (new ones prefixed by >>):
> 
> btmtkuart.c:671:18: sparse:    warning: incorrect type in assignment
> 			       (different base types)
> btmtkuart.c:671:18: sparse:    expected unsigned int [usertype] baudrate
> btmtkuart.c:671:18: sparse:    got restricted __le32 [usertype]
> 
> sparse warnings: (new ones prefixed by >>)
> btmtkuart.c:671:18: sparse: warning: incorrect type in assignment
> 			       (different base types)
> btmtkuart.c:671:18: sparse:    expected unsigned int [usertype] baudrate
> btmtkuart.c:671:18: sparse:    got restricted __le32 [usertype]
> 
> vim +671 drivers/bluetooth/btmtkuart.c
> 
>    659
>    660	static int btmtkuart_change_baudrate(struct hci_dev *hdev)
>    661	{
>    662		struct btmtkuart_dev *bdev = hci_get_drvdata(hdev);
>    663		struct btmtk_hci_wmt_params wmt_params;
>    664		u32 baudrate;
>    665		u8 param;
>    666		int err;
>    667
>    668		/* Indicate the device to enter the probe state the host is
>    669		 * ready to change a new baudrate.
>    670		 */
>  > 671		baudrate = cpu_to_le32(bdev->desired_speed);
>    672		wmt_params.op = MTK_WMT_HIF;
> 
> Fixes: 22eaf6c9946a ("Bluetooth: mediatek: add support for MediaTek MT7663U and MT7668U UART devices")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  drivers/bluetooth/btmtkuart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/bluetooth/btmtkuart.c b/drivers/bluetooth/btmtkuart.c
> index b0b680dd69f4..f5dbeec8e274 100644
> --- a/drivers/bluetooth/btmtkuart.c
> +++ b/drivers/bluetooth/btmtkuart.c
> @@ -661,7 +661,7 @@ static int btmtkuart_change_baudrate(struct hci_dev *hdev)
>  {
>  	struct btmtkuart_dev *bdev = hci_get_drvdata(hdev);
>  	struct btmtk_hci_wmt_params wmt_params;
> -	u32 baudrate;
> +	__le32 baudrate;
>  	u8 param;
>  	int err;
>