linux-kernel - Re: [V2 1/2] clk: imx6q: remove unsupported pll4_audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <155294070124.20095.17167777488324467790@swboyd.mtv.corp.google.com>
Date:   Mon, 18 Mar 2019 13:25:01 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Eric Nelson <eric@...int.com>, devicetree@...r.kernel.org,
        linux-clk@...r.kernel.org
Cc:     anson.huang@....com, colin.didier@...ialet.com, festevam@...il.com,
        kernel@...gutronix.de, l.stach@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org, linux-imx@....com,
        linux-kernel@...r.kernel.org, mark.rutland@....com,
        mturquette@...libre.com, robh+dt@...nel.org,
        s.hauer@...gutronix.de, shawnguo@...nel.org, tiny.windzz@...il.com
Subject: Re: [V2 1/2] clk: imx6q: remove unsupported pll4_audio_div

Quoting Eric Nelson (2019-03-11 13:48:55)
>  > On March 11, 2019, 6:35 p.m. UTC, Stephen Boyd wrote:
> > Quoting Eric Nelson (2019-03-11 08:59:56)
> >> + *
> >> + * Renamed to _BROKEN to prevent inadvertent use,
> >> + * but reserved the array slot to maintain DT binary
> >> + * compatibility.
> >> + */
> >> +#define IMX6QDL_CLK_PLL4_AUDIO_DIV_BROKEN      203
> > 
> > But it breaks the build. I don't get it. Just add a comment indicating
> > it shouldn't be used? That breaks the cross-tree dependency chain and
> > lets clk tree merge the clk driver part and arm-soc merge the dts part.
> The device tree update also requires the update to clk-imx6q.c
> for proper run-time operation, so I don't see how these two parts
> can be separated.
> 
> I thought about leaving the PLL4_AUDIO_DIV clock in place but
> turning it into a dummy (placeholder), but that might lead others
> down the long path I traversed before I found out that my manual
> was old and the clock didn't function.

I'm not suggesting that it's left as a dummy forever, just until the
other trees can merge their parts of this series and so that these
patches can be applied in order that they're sent. Right now, the kbuild
robot fails on this patch series because this patch intentionally breaks
the build. Please don't do that. Send patch series that are bisectable
so that the build doesn't break in the middle.