linux-kernel - Re: [PATCH v5 1/3] tracing: kdb: The skip_lines parameter should have been skip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190318171800.4b26d22d@gandalf.local.home>
Date:   Mon, 18 Mar 2019 17:18:00 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     Ingo Molnar <mingo@...hat.com>,
        Jason Wessel <jason.wessel@...driver.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        kgdb-bugreport@...ts.sourceforge.net,
        Brian Norris <briannorris@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 1/3] tracing: kdb: The skip_lines parameter should
 have been skip_entries

On Mon, 18 Mar 2019 13:47:39 -0700
Douglas Anderson <dianders@...omium.org> wrote:

> The things skipped by kdb's "ftdump" command when you pass it a
> parameter has always been entries, not lines.  The difference usually
> doesn't matter but when the trace buffer has multi-line entries (like
> a stack dump) it can matter.
> 
> Let's fix this both in the help text for ftdump and also in the local
> variable names.
> 
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
> ---

I'd like to get some acts from the kdb developers and I'll take it.

-- Steve