linux-kernel - Re: [PATCH] hostfs: fix mismatch between link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa1378b0-3048-8309-a152-8fdf5696731d@canonical.com>
Date:   Mon, 18 Mar 2019 08:41:28 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Richard Weinberger <richard@....at>
Cc:     Jeff Dike <jdike@...toit.com>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        linux-um@...ts.infradead.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and
 declaration

On 17/03/2019 23:49, Richard Weinberger wrote:
> Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> The function link_file declaration in the header file has the order
>> of the two arguments (from, to) swapped when compared to the definition
>> arguments of (to, from).  Fix this by swapping them around to match
>> the definition.
>>
>> This error predates the git history, so no idea when this error
>> was introduced.
> 
> commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd
> Author: jdike <jdike>
> Date:   Sat Dec 9 22:52:44 2000 +0000
> 
>     hostfs now mostly works.  Almost all of the common operations are now
>     implemented, the main exceptions being mknod and executing files from
>     a hostfs filesystem.
> 
> Enough archaeology for today. :-)

Nice. How do you find these ancient git commits?

> 
> Thanks,
> //richard
> 
>