linux-kernel - Re: [PATCH] hostfs: fix mismatch between link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <430554945.231221.1552898805187@ox-groupware.bfs.de>
Date:   Mon, 18 Mar 2019 09:46:44 +0100 (CET)
From:   Walter Harms <wharms@....de>
To:     kernel-janitors@...r.kernel.org
Cc:     Jeff Dike <jdike@...toit.com>, Richard Weinberger <richard@....at>,
        Anton Ivanov <anton.ivanov@...bridgegreys.com>,
        linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and
 declaration

Hi,
Colin is obvously right with that.
But my guess is that the error occured because the
pattern (from, to) is brocken here. Also 

Maybe the maintainer can fix that.

just my 2 cents,

re,
 wh


Am 18.03.2019 00:09, schrieb Colin King:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The function link_file declaration in the header file has the order
> of the two arguments (from, to) swapped when compared to the definition
> arguments of (to, from).  Fix this by swapping them around to match
> the definition.
> 
> This error predates the git history, so no idea when this error
> was introduced.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  fs/hostfs/hostfs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/hostfs/hostfs.h b/fs/hostfs/hostfs.h
> index 33b8423ef0c9..f4295aa19350 100644
> --- a/fs/hostfs/hostfs.h
> +++ b/fs/hostfs/hostfs.h
> @@ -87,7 +87,7 @@ extern int do_mkdir(const char *file, int mode);
>  extern int hostfs_do_rmdir(const char *file);
>  extern int do_mknod(const char *file, int mode, unsigned int major,
>  		    unsigned int minor);
> -extern int link_file(const char *from, const char *to);
> +extern int link_file(const char *to, const char *from);
>  extern int hostfs_do_readlink(char *file, char *buf, int size);
>  extern int rename_file(char *from, char *to);
>  extern int rename2_file(char *from, char *to, unsigned int flags);