linux-kernel - [PATCH v2 1/2] staging: gdm724x: Clean long function calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 17 Mar 2019 22:15:34 -0300
From:   Ignacio Losiggio <iglosiggio@...il.com>
To:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Cc:     Ignacio Losiggio <iglosiggio@...il.com>,
        Ignacio Losiggio <iglosiggio@...uba.ar>
Subject: [PATCH v2 1/2] staging: gdm724x: Clean long function calls

Signed-off-by: Ignacio Losiggio <iglosiggio@...uba.ar>
---
 drivers/staging/gdm724x/gdm_mux.c | 28 ++++++----------------------
 1 file changed, 6 insertions(+), 22 deletions(-)

diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c
index e2a050ba6fbb..fa8585ea1572 100644
--- a/drivers/staging/gdm724x/gdm_mux.c
+++ b/drivers/staging/gdm724x/gdm_mux.c
@@ -177,12 +177,8 @@ static int up_to_host(struct mux_rx *r)
 			break;
 		}
 
-		ret = r->callback(mux_header->data,
-				payload_size,
-				index,
-				mux_dev->tty_dev,
-				RECV_PACKET_PROCESS_CONTINUE
-				);
+		ret = r->callback(mux_header->data, payload_size, index,
+				  mux_dev->tty_dev, RECV_PACKET_PROCESS_CONTINUE);
 		if (ret == TO_HOST_BUFFER_REQUEST_FAIL) {
 			r->offset += packet_size_sum;
 			break;
@@ -190,12 +186,8 @@ static int up_to_host(struct mux_rx *r)
 
 		packet_size_sum += total_len;
 		if (len - packet_size_sum <= MUX_HEADER_SIZE + 2) {
-			ret = r->callback(NULL,
-					0,
-					index,
-					mux_dev->tty_dev,
-					RECV_PACKET_PROCESS_COMPLETE
-					);
+			ret = r->callback(NULL, 0, index, mux_dev->tty_dev,
+					  RECV_PACKET_PROCESS_COMPLETE);
 			break;
 		}
 	}
@@ -410,16 +402,8 @@ static int gdm_mux_send_control(void *priv_dev, int request, int value,
 	struct usb_device *usbdev = mux_dev->usbdev;
 	int ret;
 
-	ret = usb_control_msg(usbdev,
-			      usb_sndctrlpipe(usbdev, 0),
-			      request,
-			      USB_RT_ACM,
-			      value,
-			      2,
-			      buf,
-			      len,
-			      5000
-			     );
+	ret = usb_control_msg(usbdev, usb_sndctrlpipe(usbdev, 0), request,
+			      USB_RT_ACM, value, 2, buf, len, 5000);
 
 	if (ret < 0)
 		pr_err("usb_control_msg error: %d\n", ret);
-- 
2.21.0