linux-kernel - [PATCH 0/2] w1: DS2408 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190318092737.8170-1-manio@skyboo.net>
Date:   Mon, 18 Mar 2019 10:27:35 +0100
From:   Mariusz Bialonczyk <manio@...boo.net>
To:     linux-kernel@...r.kernel.org, Evgeniy Polyakov <zbr@...emap.net>,
        Greg Kroah-Hartman <greg@...ah.com>,
        Jean-Francois Dagenais <jeff.dagenais@...il.com>
Cc:     Mariusz Bialonczyk <manio@...boo.net>
Subject: [PATCH 0/2] w1: DS2408 fixes

Hi,
I prepared a two fixes related with 1wire and DS2408.

In short the problem was that a single DS2408 slave was properly setting
the output value to a channel access write but the command was returning
error.
Moreover when there was a write of a 0xff value (all inputs off, there was 
also no problem - it's now also understandable for me after looking
at the transmission log) ;)
This problem doesn't occur on a multidrop bus.

Finally I was able to catch the problems recently after analyzing the
oscilloscope waveforms in PulseView.
After those fixes all is now working perfectly fine - no matter if it
is multidrop or single slave bus :)

ps. if you are merging this please also take into account a patch which
I've sent recently but it is still not merged:
https://lore.kernel.org/lkml/20190304112336.21397-1-manio@skyboo.net/

regards,
Mariusz Białończyk | xmpp/e-mail: manio@...boo.net
https://skyboo.net | https://github.com/manio

Mariusz Bialonczyk (2):
  w1: ds2408: add a missing reset when retrying in output_write()
  w1: fix the resume command API

 drivers/w1/slaves/w1_ds2408.c | 13 ++++++++-----
 drivers/w1/w1_io.c            | 11 +++++++++--
 2 files changed, 17 insertions(+), 7 deletions(-)

-- 
2.19.0.rc1