linux-kernel - Re: [PATCH v9 10/12] perf report: implement record trace decompression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fd0e44e1-beec-7ebb-e617-72824dbd3399@linux.intel.com>
Date:   Mon, 18 Mar 2019 15:06:26 +0300
From:   Alexey Budankov <alexey.budankov@...ux.intel.com>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Andi Kleen <ak@...ux.intel.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v9 10/12] perf report: implement record trace
 decompression

On 18.03.2019 14:46, Jiri Olsa wrote:
> On Sat, Mar 16, 2019 at 05:17:06PM +0300, Alexey Budankov wrote:
> 
> SNIP
> 
>>  static int perf_session__deliver_event(struct perf_session *session,
>>  				       union perf_event *event,
>>  				       struct perf_tool *tool,
>> @@ -198,12 +259,23 @@ static void perf_session__delete_threads(struct perf_session *session)
>>  
>>  void perf_session__delete(struct perf_session *session)
>>  {
>> +	struct decomp *next, *decomp;
>> +	size_t decomp_len;
>>  	if (session == NULL)
>>  		return;
>>  	auxtrace__free(session);
>>  	auxtrace_index__free(&session->auxtrace_index);
>>  	perf_session__destroy_kernel_maps(session);
>>  	perf_session__delete_threads(session);
>> +	next = session->decomp;
>> +	decomp_len = session->header.env.comp_mmap_len;
>> +	do {
>> +		decomp = next;
>> +		if (decomp == NULL)
>> +			break;
>> +		next = decomp->next;
>> +		munmap(decomp, decomp_len + sizeof(struct decomp));
>> +	} while (1);
> 
> please put this to separate function

in v10.

~Alexey

> 
> thanks,
> jirka
>