lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 18 Mar 2019 15:19:13 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jose Abreu <jose.abreu@...opsys.com>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>,
        Joao Pinto <joao.pinto@...opsys.com>
Subject: Re: [PATCH net] net: phy: Don't assume loopback is supported

> We provide PHYs to our customers and in the documentation I have
> this can be an optional feature that HW team can choose to have
> or not, making the bit read-only or r/w.
> 
> Heiner, can you please confirm there is no Clause 22 "pitfalls" /
> "hidden comments" that allow this bitfield to be read-only ?

Hi Jose

I have the 802.3 standard from 2015. It should be free to download
from the IEEE. So you can go get it yourself.

Section 22.2.4.1.2 defines loopback. I don't see anything which makes
it optional. The only wiggle room you have is where in the PHY the
loopback actually takes place. That is implementation specific, but it
recommends you make it as late as possible in the path so as to test
as much as possible.

If your PHY does not implement loopback, i would say it breaks the
standard. We try to keep workarounds for brokenness in the specific
PHY driver, not the generic code.

    Andrew

Powered by blists - more mailing lists