lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 18 Mar 2019 18:33:41 +0100
From:   Oleg Nesterov <>
To:     Sudeep Holla <>
        Catalin Marinas <>,
        Will Deacon <>,
        Paul Mackerras <>,
        Michael Ellerman <>,
        Thomas Gleixner <>,
        Ingo Molnar <>,
        Richard Weinberger <>,,
        Steve Capper <>,
        Haibo Xu <>, Bin Lu <>,
        Andy Lutomirski <>
Subject: Re: [PATCH v2 4/6] powerpc: use common ptrace_syscall_enter hook to

On 03/18, Sudeep Holla wrote:
> On Mon, Mar 18, 2019 at 06:20:24PM +0100, Oleg Nesterov wrote:
> >
> > Again, to me this patch just makes the code look worse. Honestly, I don't
> > think that the new (badly named) ptrace_syscall_enter() hook makes any sense.
> >
> Worse because we end up reading current_thread_info->flags twice ?

Mostly because in my opinion ptrace_syscall_enter() buys nothing but makes
the caller's code less readable/understandable.

Sure, this is subjective.


Powered by blists - more mailing lists