linux-kernel - Re: Commit seems to prevent use of GNUmakefile wrappers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK7LNAS4zVusQRQLFNmmza9U_zbNBrjyx4qyDcH8g1oL0AzHTQ@mail.gmail.com>
Date:   Tue, 19 Mar 2019 13:05:05 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     David Howells <dhowells@...hat.com>
Cc:     Liz Zhang <lizzha@...rosoft.com>, Lili Deng <v-lide@...rosoft.com>,
        Manoj Srivastava <srivasta@...ian.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Commit seems to prevent use of GNUmakefile wrappers

Hi David,


On Mon, Mar 18, 2019 at 11:43 PM David Howells <dhowells@...hat.com> wrote:
>
> Hi Mashiro,
>
>         commit 2b50f7ab63685cd247e32ad321f7338ed130d3d5
>         Author: Masahiro Yamada <yamada.masahiro@...ionext.com>
>         kbuild: add workaround for Debian make-kpkg
>
> seems to prevent the use of GNUmakefile wrappers to set the ARCH and
> CROSS_COMPILE make variables.  With this commit, I now see:
>
>         make: Entering directory '/data/fs/linux-fs'
>         Makefile:39: Do not include top Makefile of Linux Kernel
>         ***
>         *** Configuration file ".config" not found!
>         ***
>         *** Please run some configurator (e.g. "make oldconfig" or
>         *** "make menuconfig" or "make xconfig").
>         ***
>         Makefile:605: include/config/auto.conf: No such file or directory
>         make: *** No rule to make target '.config', needed by 'include/config/auto.conf'.  Stop.
>         make: Leaving directory '/data/fs/linux-fs'
>
> Do you have a suggestion as to how to work around this?  Here's a sample
> GNUmakefile content:
>
>         CROSS_COMPILE   := x86_64-linux-gnu-
>         ARCH            := x86_64
>         MFLAGS          += CROSS_COMPILE=$(CROSS_COMPILE) ARCH=$(ARCH)
>         export CROSS_COMPILE
>         export ARCH
>         include Makefile


I think the following will work.
(code was taken from scripts/mkmakefile)



------------------(GNUmakefile BEGIN)-------------------
CROSS_COMPILE   := x86_64-linux-gnu-
ARCH            := x86_64
MFLAGS          += CROSS_COMPILE=$(CROSS_COMPILE) ARCH=$(ARCH)
export CROSS_COMPILE
export ARCH

ifeq ("$(origin V)", "command line")
VERBOSE := $(V)
endif
ifneq ($(VERBOSE),1)
Q := @
endif

MAKEFLAGS += --no-print-directory

.PHONY: __sub-make $(MAKECMDGOALS)

__sub-make:
        $(Q)$(MAKE) -f Makefile $(MAKECMDGOALS)

$(filter-out __sub-make, $(MAKECMDGOALS)): __sub-make
        @:
------------------(GNUmakefile END)-------------------



Having said that, the previous cheesy workaround sucks.

How about this patch?
https://patchwork.kernel.org/patch/10858809/

I hope you will be able to wrap the top Makefile again.


--
Best Regards
Masahiro Yamada