linux-kernel - Re: [GIT PULL] Driver core patches for 5.1-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190319171230.780c0771@canb.auug.org.au>
Date:   Tue, 19 Mar 2019 17:12:30 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Joe Perches <joe@...ches.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux List Kernel Mailing <linux-kernel@...r.kernel.org>,
        Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>
Subject: Re: [GIT PULL] Driver core patches for 5.1-rc1

Hi Linus,

On Wed, 6 Mar 2019 15:47:11 -0800 Linus Torvalds <torvalds@...ux-foundation.org> wrote:
>
> This is very funky, but that commit generates a new warning in a
> totally unrelated area:
> 
>   drivers/iio/adc/qcom-pm8xxx-xoadc.c: In function ‘pm8xxx_xoadc_probe’:
>   drivers/iio/adc/qcom-pm8xxx-xoadc.c:633:8: warning: ‘ch’ may be used
> uninitialized in this function [-Wmaybe-uninitialized]
>     ret = pm8xxx_read_channel_rsv(adc, ch, AMUX_RSV4,
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>              &read_nomux_rsv4, true);
>              ~~~~~~~~~~~~~~~~~~~~~~~
>   drivers/iio/adc/qcom-pm8xxx-xoadc.c:426:27: note: ‘ch’ was declared here
>     struct pm8xxx_chan_info *ch;
>                              ^~
> 
> I wonder why this wasn't seen in linux-next?

It is possible I missed it because I am currently building with
-Wimplicit-fallthrough to help Kees and co with their attempt at making
that a "normal" build flag for the kernel.  Unfortunately it generates
a few hundred warnings still.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped