linux-kernel - Re: [PATCH] usb: usb251xb: Remove unnecessary comparison of unsigned integer with >= 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0c4531b-0590-6587-0aa7-9ca05a1b5c7c@skidata.com>
Date:   Tue, 19 Mar 2019 10:33:43 +0100
From:   Richard Leitner <richard.leitner@...data.com>
To:     Marco Felsch <m.felsch@...gutronix.de>
CC:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: usb251xb: Remove unnecessary comparison of unsigned
 integer with >= 0


On 18/03/2019 17:48, Marco Felsch wrote:
> On 19-03-18 16:46, Richard Leitner wrote:
>> A small note on further improvement from my side:
>>
>> According the datasheet, when you set swap-dx-lanes to 0 (-> setting port to
>> 0 -> setting bit 0 of PRTSP) "   the upstream port DP/DM is swapped".
> 
> Yes I know that's not intuitve and may confuses the users.
> 
>> IMHO this is not straight-forward, so maybe we want to additionally
>>
>> 	a) mention it somewhere in the documentation
> 
> IMHO this is the correct place.
> 
>> 	b) check on port >= 1
> 
> I think this isn't doable since we shouldn't break the existing dt.

ACK.

@Marco/Gustavo: does one of you wants to provide a patch for this?

> 
> Regards,
> Marco
> 
>> 	c) something else?
>>
>> Any opinions on that from your side? ... I'd prefer "a"...

regards;Richard.L