linux-kernel - Re: [PATCH] mISDN: hfcpci: Test both vendor & device ID for Digium HFC4S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190318.183353.1537778009455064073.davem@davemloft.net>
Date:   Mon, 18 Mar 2019 18:33:53 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     helgaas@...nel.org
Cc:     isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, bhelgaas@...gle.com
Subject: Re: [PATCH] mISDN: hfcpci: Test both vendor & device ID for Digium
 HFC4S

From: helgaas@...nel.org
Date: Mon, 18 Mar 2019 08:51:06 -0500

> From: Bjorn Helgaas <bhelgaas@...gle.com>
> 
> The device ID alone does not uniquely identify a device.  Test both the
> vendor and device ID to make sure we don't mistakenly think some other
> vendor's 0xB410 device is a Digium HFC4S.  Also, instead of the bare hex
> ID, use the same constant (PCI_DEVICE_ID_DIGIUM_HFC4S) used in the device
> ID table.
> 
> No functional change intended.
> 
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>

Applied, thanks.