linux-kernel - Re: [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190319103659.GA3178@localhost>
Date:   Tue, 19 Mar 2019 11:36:59 +0100
From:   Johan Hovold <johan@...nel.org>
To:     Oliver Neukum <oneukum@...e.com>
Cc:     Karoly Pados <pados@...os.hu>, Johan Hovold <johan@...nel.org>,
        Loic Poulain <loic.poulain@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] USB: serial: cp210x: Fix GPIO in autosuspend

On Mon, Feb 18, 2019 at 10:17:12AM +0100, Oliver Neukum wrote:
> On So, 2019-02-17 at 18:59 +0100, Karoly Pados wrote:
> > Current GPIO code in cp210x fails to take USB autosuspend into account,
> > making it practically impossible to use GPIOs with autosuspend enabled
> > without user configuration. Fix this like for ftdi_sio in a previous patch.
> > Tested on a CP2102N.

> your patch is looking good to me, but I am afraid there are issues.
> How do the GPIO lines on the device interact with USB reset and system
> suspend?

What was your concern here, Oliver?

Johan