linux-kernel - Re: [PATCH] scsi: ufs: Fix to avoid a potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGOxZ52QBKS3BtKyjiSxaGBW5piLGM_Lr9WQk8_Ernbq9Ehz7g@mail.gmail.com>
Date:   Tue, 19 Mar 2019 07:15:07 +0530
From:   Alim Akhtar <alim.akhtar@...il.com>
To:     Aditya Pakki <pakki001@....edu>
Cc:     kjlu@....edu, Pedro Sousa <pedrom.sousa@...opsys.com>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Avri Altman <avri.altman@....com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: ufs: Fix to avoid a potential NULL pointer dereference

On Tue, Mar 19, 2019 at 6:01 AM Aditya Pakki <pakki001@....edu> wrote:
>
> In tc_dwc_g210_pltfm_probe, of_match_node can return a NULL pointer
> in case of failure. The patch avoids a potential NULL pointer dereference
> in such scenarios.
>
> Signed-off-by: Aditya Pakki <pakki001@....edu>
> ---
>  drivers/scsi/ufs/tc-dwc-g210-pltfrm.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/scsi/ufs/tc-dwc-g210-pltfrm.c b/drivers/scsi/ufs/tc-dwc-g210-pltfrm.c
> index 6dfe5a9206e9..2b5bc6bd715e 100644
> --- a/drivers/scsi/ufs/tc-dwc-g210-pltfrm.c
> +++ b/drivers/scsi/ufs/tc-dwc-g210-pltfrm.c
> @@ -61,6 +61,8 @@ static int tc_dwc_g210_pltfm_probe(struct platform_device *pdev)
>         struct device *dev = &pdev->dev;
>
>         of_id = of_match_node(tc_dwc_g210_pltfm_match, dev->of_node);
> +       if (!of_id)
> +               return -ENXIO;
May be just return -ENODEV
>         vops = (struct ufs_hba_variant_ops *)of_id->data;
>
>         /* Perform generic probe */
> --
> 2.17.1
>


-- 
Regards,
Alim